Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck to ci for linting scripts #148

Open
matifali opened this issue Feb 7, 2024 · 2 comments
Open

add shellcheck to ci for linting scripts #148

matifali opened this issue Feb 7, 2024 · 2 comments
Assignees
@mafredri
Labels
scaffolding

Comments

@matifali
Copy link
Member

matifali commented Feb 7, 2024

We already have shfmt it would be nice to also lint using shellcheck.

@mafredri I would appreciate it if you could do this sometimes. It's not a high priority, just something we should do at some point.
@mafredri
Copy link
Member

This came up in #297 (comment)

Assigning this to me now so I don't lose track.

@mafredri mafredri self-assigned this Sep 27, 2024
@mafredri
Copy link
Member

Posted a proposal in #331 (comment) that would allow us shellcheck both library code (lib.sh) and the main shell code (run.sh). This issue is currently pending whether or not we go forward with this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
scaffolding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mafredri @matifali