add toolchainclusterresources controller

[mfrancisc]

Enable the toolchainclusterresources controller that will create all the required resources for the toolchaincluster CR.
The resources are defined as embed.FS type in deploy.ToolchainClusterTemplateFS variable

The add-cluster script will be cleaned up once this PR and the equivalent one in member-operator will be merged.

e2e pr: codeready-toolchain/toolchain-e2e#945

Depends on: codeready-toolchain/toolchain-common#385

Jira: https://issues.redhat.com/browse/KUBESAW-24

[rsoaresd]

Hello, @mfrancisc

I noticed that it is failing with EOF:

Error:      	Received unexpected error:
        	            	Get "https://host-operator-metrics-service-toolchain-host-04125046.apps.ci-op-rv2x2c9b-1de72.devsandboxci.devcluster.openshift.com/metrics": EOF
        	Test:       	TestAfterMigration

The related PR in member-operator is failing with EOF too:

Error:      	Received unexpected error:
        	            	Post "https://registration-service-toolchain-host-04125414.apps.ci-op-wsw002nh-887d4.devsandboxci.devcluster.openshift.com/api/v1/signup": EOF
        	Test:       	TestAfterMigration/run_migration_setup_with_new_operator_versions_for_compatibility

[mfrancisc]

I noticed that it is failing with EOF

@rsoaresd thanks for investigating and pointing this out 🙏

I'm looking into it, trying to reproduce locally , but having some other dev infrastructure issues atm 🤦

[rsoaresd]

@mfrancisc I can try to reproduce locally too :)

I am tracking the occurrences through this search query

[mfrancisc]

I am tracking the occurrences through this search query

@rsoaresd nice! I wasn't aware of this search tool 😮 . Thanks for sharing!

It seems that it happened only on my PR, so maybe related to my changes 🤔

[alexeykazakov]

Looks good. However there is a bit of inconsistency in how we organize templates in the host and member operators.
In the host we keep them in /deploy/templates while in the member there are in /deploy. Not sure if we want to do anything about that though.
But anyway we can address it in a separate PR if we want.

[mfrancisc]

However there is a bit of inconsistency in how we organize templates in the host and member operators.
In the host we keep them in /deploy/templates while in the member there are in /deploy

@alexeykazakov thanks for the review and good point. I've updated member-operator to store the templates under deploy/templates/ in codeready-toolchain/member-operator@7bb3fb9

[mfrancisc]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfrancisc]

/retest

flaky : https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/codeready-toolchain_host-operator/1007/pull-ci-codeready-toolchain-host-operator-master-e2e/1779985265461301248/build-log.txt

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[codecov]

Codecov Report

Merging #1007 (f697950) into master (4d53fb0) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   84.85%   84.87%   +0.01%     
==========================================
  Files          55       55              
  Lines        5066     5066              
==========================================
+ Hits         4299     4300       +1     
+ Misses        584      583       -1     
  Partials      183      183              

see 1 file with indirect coverage changes