registration-service: new Service for metrics #1050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new k8s Service to scrape the HTTP metrics from the registration service, but without exposing them to the current Route (the metrics will be exposed in a separate port in the registration service pods) see codeready-toolchain/registration-service#436 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
requested review from
MatousJobanek,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xcoulon
commented
Jun 24, 2024
| - kind: Service | ||
| apiVersion: v1 | ||
| metadata: | ||
| name: api | ||
| name: registration-service |
There was a problem hiding this comment.
I reordered the Routes and Services and added a few comments, but unfortunately, the diff doesn't clearly shows how the items were reordered :/
|
closing in favor of #1051 (duplicate branch name) |
xcoulon
added a commit
to xcoulon/toolchain-e2e
that referenced
this pull request
Jun 24, 2024
Related to codeready-toolchain/registration-service#436 New tests to verify that: 1. the metrics are _not_ exposed on the public Route 2. the expected metrics are available from the new Service[1] - tested from the outside of the cluster by creating a temporary Route [1]: see codeready-toolchain/host-operator#1050 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
to codeready-toolchain/toolchain-e2e
that referenced
this pull request
Jul 3, 2024
Related to codeready-toolchain/registration-service#436 New tests to verify that: 1. the metrics are _not_ exposed on the public Route 2. the expected metrics are available from the new Service[1] - tested from the outside of the cluster by creating a temporary Route [1]: see codeready-toolchain/host-operator#1050 --------- Signed-off-by: Xavier Coulon <[email protected]> Co-authored-by: Alexey Kazakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new k8s Service to scrape the HTTP metrics from the registration
service, but without exposing them to the current Route
(the metrics will be exposed in a separate port in the
registration service pods)
see codeready-toolchain/registration-service#436
Signed-off-by: Xavier Coulon [email protected]