-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new ttr for tiertemplate updates #1130
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest updated e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have 2 slight readability improvement suggestions, otherwise looks great!
Co-authored-by: Lukas Krejci <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 79.53% 79.52% -0.02%
==========================================
Files 80 80
Lines 8086 8096 +10
==========================================
+ Hits 6431 6438 +7
- Misses 1470 1472 +2
- Partials 185 186 +1
|
Quality Gate passedIssues Measures |
@mfrancisc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR triggers a TTR creation when the tiertemlpate content changes or there is a change in the NSTemplateTier parameters field.
follow up from #1103
Paired with: codeready-toolchain/toolchain-e2e#1102
Jira: https://issues.redhat.com/browse/KUBESAW-257