Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new ttr for tiertemplate updates #1130

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Jan 24, 2025

This PR triggers a TTR creation when the tiertemlpate content changes or there is a change in the NSTemplateTier parameters field.

follow up from #1103

Paired with: codeready-toolchain/toolchain-e2e#1102

Jira: https://issues.redhat.com/browse/KUBESAW-257

mfrancisc and others added 27 commits December 7, 2023 12:21
Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfrancisc
Copy link
Contributor Author

/retest

updated e2e

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have 2 slight readability improvement suggestions, otherwise looks great!

@mfrancisc mfrancisc requested a review from metlos January 30, 2025 15:40
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (e2d2b30) to head (8512d2a).

Files with missing lines Patch % Lines
...ollers/nstemplatetier/nstemplatetier_controller.go 69.56% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   79.53%   79.52%   -0.02%     
==========================================
  Files          80       80              
  Lines        8086     8096      +10     
==========================================
+ Hits         6431     6438       +7     
- Misses       1470     1472       +2     
- Partials      185      186       +1     
Files with missing lines Coverage Δ
test/nstemplatetier/assertion.go 100.00% <100.00%> (ø)
...ollers/nstemplatetier/nstemplatetier_controller.go 82.23% <69.56%> (-1.22%) ⬇️

Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link

openshift-ci bot commented Feb 4, 2025

@mfrancisc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e d17e8d2 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants