Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play with demo" on home page scrolls to wrong location #2376

Open
Flimm opened this issue Jun 6, 2023 · 3 comments
Open

"Play with demo" on home page scrolls to wrong location #2376

Flimm opened this issue Jun 6, 2023 · 3 comments

Comments

@Flimm
Copy link

Flimm commented Jun 6, 2023

I want to try out editor.js before investing more time in it. So I visit the home page https://editorjs.io/ , and I click the button labelled "Play with demo", as you can see in this screenshot:

Screenshot

When I click the button "Play with demo", it scrolls to this part of the home page:

Screenshot

As you can see, the part of the screen that is displayed is "Clean JSON output". This made me think that the demo was trying to demonstrate example JSON output. But I wanted to try the editor.js editor out. It turns out, I needed to scroll up to see the demo. I experienced this issue using Firefox and using Chrome on Ubuntu 23.04.

I spent maybe twenty minutes on this, exploring other demos that I found by Googling, but I only realised now that there is a demo page in the home page.

My suggestion:

  1. Fix the scrolling issue so that I can see the demo immediately, rather on hoping on the user figuring out that they need to scroll up after pressing the button
  2. Or... provide a separate web page for the demo, to sidestep scrolling issues altogether. (Also, this would be better for those searching for a editor.js demo using a search engine like Google)
@devrajgadhvi
Copy link

I would like to address this issue. Can someone let me know what should be done?

@neSpecc
Copy link
Member

neSpecc commented Jun 7, 2023

@devrajgadhvi for now there is a simple scrollIntoView used:
https://github.com/codex-team/editorjs.io/blob/main/components/EditorOverview.vue#L70

You need to improve the scrolling logic.

@VKR981
Copy link

VKR981 commented Aug 15, 2023

@neSpecc I have created a PR codex-team/editorjs.io#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants