Fix issues with shape drawing on initialize #860
Conversation
andrewkfiedler
commented
Jan 3, 2024
andrewkfiedler
commented
- Updates the Query model to set the correct cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today
- Removes a timeout effect that would inadvertantly use old data and possible cause shapes to disappear from the map.
- Updates the drawing / display component to useCallback
|
An updated dist branch has been created and pushed to origin. Remember to use "yarn install --force" if you want to pick up changes each time you make a change to this branch by committing. |
- Updates the Query model to set the right cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today - Removes a timeout effect that would inadvertantly use old data and cause the shapes to disappear from the map. - Updates the drawing / display component to useCallback so that we can ensure we're handling updates correctly
andrewkfiedler
force-pushed
the
FixShapeDrawing
branch
from
696e73f to
f6cfbd0
Compare
|
An updated dist branch has been created and pushed to origin. Remember to use "yarn install --force" if you want to pick up changes each time you make a change to this branch by committing. |
alexabird
added
Needs hero
Hero in progress
Hero was successful
and removed
Needs review
Needs hero
Hero in progress
labels
|
Hero Successful Screen.Recording.2024-01-08.at.5.41.21.PM.mov |
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
|
You can no longer use: Instead, if the pr was merged you can now access these changes by using: Remember to use "yarn install --force" if you want to pick up changes to this version. |
- Updates the Query model to set the right cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today - Removes a timeout effect that would inadvertantly use old data and cause the shapes to disappear from the map. - Updates the drawing / display component to useCallback so that we can ensure we're handling updates correctly
- Updates the Query model to set the right cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today - Removes a timeout effect that would inadvertantly use old data and cause the shapes to disappear from the map. - Updates the drawing / display component to useCallback so that we can ensure we're handling updates correctly
- Updates the Query model to set the right cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today - Removes a timeout effect that would inadvertantly use old data and cause the shapes to disappear from the map. - Updates the drawing / display component to useCallback so that we can ensure we're handling updates correctly
- Updates the Query model to set the right cql / filterTree on both itself and the LazyResult object right at construction time, preventing weirdness that could arise from the slight delay we have today - Removes a timeout effect that would inadvertantly use old data and cause the shapes to disappear from the map. - Updates the drawing / display component to useCallback so that we can ensure we're handling updates correctly Co-authored-by: Andrew Fiedler <[email protected]>
