Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preference syncing across windows #868

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

andrewkfiedler
Copy link
Contributor

  • If golden layout happened to be open during uploads, weirdness would occur as uploads would be replaced during preferences syncs.
  • This updates our consumption of preference events to be particular about ignoring events from the window emitting them. Might be worth doing the same for other events we have in this file, if only for performance purposes.

 - If golden layout happened to be open during uploads, weirdness would occur as uploads would be replaced during preferences syncs.
 - This updates our consumption of preference events to be particular about ignoring events from the window emitting them.  Might be worth doing the same for other events we have in this file, if only for performance purposes.
Copy link

An updated dist branch has been created and pushed to origin.
You can use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-868",
in your package.json to use this version in your project.

Remember to use "yarn install --force" if you want to pick up changes each time you make a change to this branch by committing.

github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
@alexabird
Copy link
Collaborator

build now

@cxddfuibot
Copy link
Collaborator

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@alexabird alexabird merged commit 3ec2f7c into master Jan 18, 2024
3 checks passed
Copy link

You can no longer use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-868",
in your package.json to use this version in your project, as it has been deleted now that the pull request is closed.

Instead, if the pr was merged you can now access these changes by using:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-snapshot",

Remember to use "yarn install --force" if you want to pick up changes to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants