Allow unsuccessful results to be counted #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlcsmith
approved these changes
Jul 26, 2024
glenhein
approved these changes
Jul 26, 2024
sgalla
approved these changes
Jul 26, 2024
andrewkfiedler
approved these changes
Jul 26, 2024
|
build now |
|
Internal build has been started, your results will be available at build completion. |
pvargas
approved these changes
Jul 26, 2024
malmgrens4
approved these changes
Jul 26, 2024
|
Build ABORTED See the job results in legacy Jenkins UI or in Blue Ocean UI. |
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some federated sources can produce error details but still return results. Currently, when the UI receives results from a query for a source that indicates an error, the available and possible counts reported do not include updates from "unsuccessful" sources. This means that if the source did in fact return results, they would be displayed to the user in the results visual but the status in the heartbeat area would indicate that there were zero results. This is a confusing state for the user to be in.
This PR removes the filtering of unsuccessful results so that all of the returned data is counted appropriately.