Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to scroll to the top of the page, when showing pages #418

Open
5 tasks
abhishek97 opened this issue May 26, 2019 · 2 comments · May be fixed by #583
Open
5 tasks

We need to scroll to the top of the page, when showing pages #418

abhishek97 opened this issue May 26, 2019 · 2 comments · May be fixed by #583
Labels
BOSS BOUNTY: 100

Comments

@abhishek97
Copy link
Contributor

By Default, the scroll position is preserved while transitioning routes. However, at times this isn't the desired behaviour.
We need to scroll to top for the following pages:

  • Home
  • All Courses
  • My Courses
  • Course Timeline (Course Overview)
  • Course/:id

How ?

Use ember-router-scroll plugin, and use the mixin at the mentioned routes.

Don't window.scrollTop(0, 0) in beforeModel or similar hook. This will not preserve scroll position when using browser's back button. #DontBreakTheWeb
@sourabh1031
Copy link

Working on this

@sourabh1031 sourabh1031 mentioned this issue May 27, 2019
Closed
@crusader2000 crusader2000 mentioned this issue Jul 16, 2019
Closed
@IsomerX
Copy link

IsomerX commented May 15, 2020

Is this still open?

@samagragupta samagragupta linked a pull request May 31, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BOSS BOUNTY: 100
Projects
None yet
Milestone
No milestone
3 participants
@abhishek97 @sourabh1031 @IsomerX