Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julian calendar #46

Open
paolap opened this issue Mar 7, 2022 · 3 comments
Open

Add Julian calendar #46

paolap opened this issue Mar 7, 2022 · 3 comments

Comments

@paolap
Copy link
Member

paolap commented Mar 7, 2022

I can actually treat Julian calendar exactly as a 365.25, so calling add_doi function to convert it to a 366 days year.

@linncarl
Copy link

Hi, I can't read anywhere about how you treat leap years, or specifically the leap day of the 29th of February when calcualting MHW days. The climatologies from the outcome of the threshold() function have 366 days (assuming one uses daily values). Assume one having 10 years of daily values, with two of them consisting of 366 days due to leap years, and the rest is 365 days. How do the detect() function calculate the marine heat waves across all these years using a climatology of 366 days? In short, how do you handle the leap days?

Best regards,
Linn

@paolap
Copy link
Member Author

paolap commented Aug 25, 2024

28 Feb, 29 feb and 1st of March get averaged to provide a value for 29 of Feb, unless using a 360 days calendar.

@linncarl
Copy link

Ok, so you do that to provide a value for the climatology, but then using the detect function, how is it calcualted for the non-leap years running a 366 day climatology to detect MHWs? You just skip that day for those years?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants