Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide status field for Reply #348

Closed
MrOrz opened this issue Sep 27, 2024 · 0 comments · Fixed by #349
Closed

Provide status field for Reply #348

MrOrz opened this issue Sep 27, 2024 · 0 comments · Fixed by #349

Comments

@MrOrz
Copy link
Member

MrOrz commented Sep 27, 2024 •
edited
Loading

Ref: https://g0v-slack-archive.g0v.ronny.tw/index/channel/C2PPMRQGP/2024-09#ts-1727166071.414649

We are receiving emails requesting us to take down replies by already-blocked users.

We currently cannot achieve this because we do not expose enough information in API for the clients (rumors-site) to hide the page.

Proposed changes:

  • Add status to Reply object. The value can share the same enum as ArticleReply's status. We implement a GraphQL resolver for that field to resolve status by detecting if its author has been blocked, or if all article replies are already deleted.
  • Also make changes to rumors-site (Hide replies by blocked users rumors-site#577)

This change will also help cofacts/rumors-site#456 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add status field to Reply cofacts/rumors-api
1 participant
@MrOrz