Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering article page from article list takes 2 back to go back to list page #211

Closed
MrOrz opened this issue Feb 2, 2020 · 5 comments
Closed
Labels

Comments

@MrOrz
Copy link
Member

MrOrz commented Feb 2, 2020

image

Steps to reproduce

  1. Enter list page https://cofacts.g0v.tw/articles?filter=solved
  2. Click any of article to enter article page
  3. Wait for the search trend iframe to load
  4. Press back on browser

Expected

The browser stops loading and go back to article list

Actual

The browser stays at article page. When search trend is loaded, it displays a huge number (indicating that article id is gone, but list page not loaded instead)

@normanlinnet
Copy link
Contributor

A similar problem: 看起來類似的問題
remix-run/react-router#6259

@MrOrz
Copy link
Member Author

MrOrz commented Feb 15, 2020

Cool. Not sure if router used by next.js share similar root cause.

@jihchi
Copy link
Contributor

jihchi commented May 26, 2020

I've observed that we won't get the issue if you comment out the <Trendline /> component which is aligned with iframe issue that @normanlinnet mentioned.

I'll continue to dig into the problem and see if I can find a way to solve it.

@MrOrz
Copy link
Member Author

MrOrz commented May 26, 2020

Thank you @jihchi for locating the component that caused this issue!

We recently have plans to replace the iframe with line charts (data from Google Analytics reporting API). Let's hope the problem can go away soon.

Removing "good first issue" because the root cause is identified as something we are going to deprecate soon.

@MrOrz
Copy link
Member Author

MrOrz commented Sep 9, 2020

Confirmed that it's fixed via #314.

@MrOrz MrOrz closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants