Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci integration testing is broken #236

Open
vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments
Open

ci integration testing is broken #236

vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
P-medium Medium priority
Milestone

Comments

@vincenzopalazzo
Copy link
Contributor

Due that lightningd/plugin change in the guidance and also the policy our integration testing is broken, we should find a solution for it

cc @tareknaser

@vincenzopalazzo vincenzopalazzo added 🐛 - bug Something isn't working 💭 - brainstorming feature idea and related discussion labels Feb 7, 2024
@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Feb 7, 2024
@vincenzopalazzo vincenzopalazzo changed the title ci integration testint is broken ci integration testing is broken Feb 7, 2024
@tareknaser
Copy link
Collaborator

Yes
most of our integration testing depends on summary and helpme as sample python plugins
we should find another python plugin that is easy to test with cln as well

Maybe monitor?

@vincenzopalazzo
Copy link
Contributor Author

I was wondering if we should look inside other directory if a directory is not a plugin directory :/

This make the indexing a little bit more complex but sounds a good solution also for the future?

@vincenzopalazzo vincenzopalazzo added P-medium Medium priority and removed 🐛 - bug Something isn't working 💭 - brainstorming feature idea and related discussion labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants