You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into an issue where i had the same plugin listed 3 times under coffee list. Since we internally use Vec to store these there is no check for duplicates on a Vec.push. We could switch to something like HashMap<String, Plugin> and use the name as the key or on every Vec.push we check if a plugin with that name already exists to prevent cases like this. I'd be willing to make these changes.
Thoughts?
The text was updated successfully, but these errors were encountered:
daywalker90
changed the title
Use HashMap instead of Vec for plugins
Check for duplicate plugin
Feb 26, 2024
I ran into an issue where i had the same plugin listed 3 times under
coffee list
. Since we internally useVec
to store these there is no check for duplicates on aVec.push
. We could switch to something likeHashMap<String, Plugin>
and use thename
as the key or on everyVec.push
we check if a plugin with thatname
already exists to prevent cases like this. I'd be willing to make these changes.Thoughts?
The text was updated successfully, but these errors were encountered: