allow None for workflowExecutionId in WorkflowTriggerRun #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 90.78% 90.77% -0.01%
==========================================
Files 126 126
Lines 19698 19700 +2
==========================================
+ Hits 17882 17883 +1
- Misses 1816 1817 +1
|
VerstraeteBert
approved these changes
Sep 3, 2024
CHANGELOG.md
Outdated
| @@ -17,6 +17,11 @@ Changes are grouped as follows | |||
| - `Fixed` for any bug fixes. | |||
| - `Security` in case of vulnerabilities. | |||
|
|
|||
| ## [7.56.1] - 2024-09-03 | |||
| ### Fixed | |||
| - [Feature Preview - alpha] data workflows: `workflowExecutionId` in `cognite.client.data_classes.workflows.WorkflowTriggerRun` | |||
There was a problem hiding this comment.
Suggested change
| - [Feature Preview - alpha] data workflows: `workflowExecutionId` in `cognite.client.data_classes.workflows.WorkflowTriggerRun` | |
| - [Feature Preview - beta] data workflows: `workflowExecutionId` in `cognite.client.data_classes.workflows.WorkflowTriggerRun` |
consistent with the previous changelog
doctrino
approved these changes
Sep 3, 2024
spec is wrong, we need to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.