Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable: Set up logging in extractor based on application config #405

Merged
merged 2 commits into from
Dec 2, 2024

Merge branch 'master' into setup-logging

65fcadd
Select commit
Loading
Failed to load commit list.
Merged

unstable: Set up logging in extractor based on application config #405

Merge branch 'master' into setup-logging
65fcadd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

74.00% (-0.43%) compared to 658fa18

View this Pull Request on Codecov

74.00% (-0.43%) compared to 658fa18

Details

Codecov Report

Attention: Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.

Project coverage is 74.00%. Comparing base (658fa18) to head (65fcadd).

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/base.py 20.68% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   74.43%   74.00%   -0.43%     
==========================================
  Files          41       41              
  Lines        3313     3343      +30     
==========================================
+ Hits         2466     2474       +8     
- Misses        847      869      +22     
Files with missing lines Coverage Δ
...te/extractorutils/unstable/configuration/models.py 85.90% <100.00%> (+0.19%) ⬆️
cognite/extractorutils/unstable/core/base.py 60.55% <20.68%> (-7.87%) ⬇️

... and 1 file with indirect coverage changes