Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #396. If we have two identical objects in the
Var
overrides, the previous code would allow theLinExpr
constructor to void anything but the last coefficient.I also added the relevant tests, which now pass. The last constraint would fail, because I only modified the
Var
functions, not the constructor itself.Alternative:
However, this would tank a performance slightly if users create the
LinExpr
manually. For this benchmark, theusing_lists
method runs in 0.71s vs 0.33s forn=2000
. Considering the last change was made due to performance reasons, I did not want to revert this right away, but feel free to approve this.