From e9666a23142d285f0f9dd8f12fdfe2af09d475d8 Mon Sep 17 00:00:00 2001 From: jingwei zhuang Date: Sun, 28 Aug 2022 15:10:38 -0700 Subject: [PATCH 1/2] remove max_fee and mulltiplier in preprocess --- api.json | 13 +------------ api.yaml | 20 -------------------- 2 files changed, 1 insertion(+), 32 deletions(-) diff --git a/api.json b/api.json index 16ee2c1..731c269 100644 --- a/api.json +++ b/api.json @@ -1996,7 +1996,7 @@ } }, "ConstructionPreprocessRequest": { - "description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. The caller can provide a max fee they are willing to pay for a transaction. This is an array in the case fees must be paid in multiple currencies. The caller can also provide a suggested fee multiplier to indicate that the suggested fee should be scaled. This may be used to set higher fees for urgent transactions or to pay lower fees when there is less urgency. It is assumed that providing a very low multiplier (like 0.0001) will never lead to a transaction being created with a fee less than the minimum network fee (if applicable). In the case that the caller provides both a max fee and a suggested fee multiplier, the max fee will set an upper bound on the suggested fee (regardless of the multiplier provided).", + "description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. In the case that the caller provides both a max fee and a suggested fee multiplier, the max fee will set an upper bound on the suggested fee (regardless of the multiplier provided).", "type":"object", "required": [ "network_identifier", @@ -2014,17 +2014,6 @@ }, "metadata": { "type":"object" - }, - "max_fee": { - "type":"array", - "items": { - "$ref":"#/components/schemas/Amount" - } - }, - "suggested_fee_multiplier": { - "type":"number", - "format":"double", - "minimum": 0 } } }, diff --git a/api.yaml b/api.yaml index 80d834e..214949f 100644 --- a/api.yaml +++ b/api.yaml @@ -1204,18 +1204,6 @@ components: required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. - The caller can provide a max fee they are willing - to pay for a transaction. This is an array in the case fees - must be paid in multiple currencies. - - The caller can also provide a suggested fee multiplier - to indicate that the suggested fee should be scaled. - This may be used to set higher fees for urgent transactions - or to pay lower fees when there is less urgency. It is assumed - that providing a very low multiplier (like 0.0001) will - never lead to a transaction being created with a fee - less than the minimum network fee (if applicable). - In the case that the caller provides both a max fee and a suggested fee multiplier, the max fee will set an upper bound on the suggested fee (regardless of the @@ -1233,14 +1221,6 @@ components: $ref: '#/components/schemas/Operation' metadata: type: object - max_fee: - type: array - items: - $ref: '#/components/schemas/Amount' - suggested_fee_multiplier: - type: number - format: double - minimum: 0.0 ConstructionPreprocessResponse: description: | ConstructionPreprocessResponse contains `options` that will From 26ff9dd16bd35672d679fec0edd2de04a4e95e36 Mon Sep 17 00:00:00 2001 From: jingwei zhuang Date: Mon, 19 Sep 2022 00:58:00 -0700 Subject: [PATCH 2/2] updates --- api.json | 2 +- api.yaml | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/api.json b/api.json index 731c269..b38868f 100644 --- a/api.json +++ b/api.json @@ -1996,7 +1996,7 @@ } }, "ConstructionPreprocessRequest": { - "description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. In the case that the caller provides both a max fee and a suggested fee multiplier, the max fee will set an upper bound on the suggested fee (regardless of the multiplier provided).", + "description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`.", "type":"object", "required": [ "network_identifier", diff --git a/api.yaml b/api.yaml index 214949f..679b937 100644 --- a/api.yaml +++ b/api.yaml @@ -1203,11 +1203,6 @@ components: data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. - - In the case that the caller provides both a max fee - and a suggested fee multiplier, the max fee will set an - upper bound on the suggested fee (regardless of the - multiplier provided). type: object required: - network_identifier