-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataAPI for address validation #72
Comments
Thanks for posting about this, @LanfordCai!
We perform this sort of logic check prior to invoking Rosetta but I see the appeal in having it integrated directly into the implementation. I think the responsibility to do this sort of rejection should fall on the implementation. Maybe the best way to enforce this would be to add some testing to
We've been thinking about this problem a lot lately (multiple address formats). Right now, Rosetta doesn't really have a notion of different address types and it is creating some confusion for folks trying to integrate with
Do you envision this being |
Hi, thank you for your response, @patrick-ogrady !
In our exchange, basically three steps are involved in the withdrawal process:
It would be better if step 1 can also be done by calling a specific Rosetta API. I think with Rosetta, we don't need to know lots of technical details about the blockchain, including how to validate an address(which requires knowledge about the address generation process). It is indeed acceptable to return ‘error’ when creating a transaction with invalid address, but it would be better if we can reject the invalidate address before creating the transaction.
It would be great if we can specify address types when deriving an address and getting the type information in
For format validation, But if we take a further step, some information about an address is only available in EOS Premium Account:
EOS Normal Account:
BCH Address:
|
Thanks for providing this additional context, @LanfordCai. I'd recommend you chime in on a thread about a different use for |
I'm working for an exchange and have integrated a blockchain by using Rosetta. This project is really amazing and is well compatible with our current blockchain integration process. But there is a feature I want to request.
Is your feature request related to a problem? Please describe.
We will check the address that the customer input in the withdrawal process:
1JTxUeSwH5Ba2ib2UD6Whv5ZXB8RRjfRM8
is a valid address but1JTxUeSwH5Ba2ib2UD6Whv5ZXB8RRjfRM9
is not.For the blockchain we have integrated via Rosetta, I used
/account/balance
to check if the address is valid or not; For invalid address, it would returninvalid account name
. But I think it's just a workaround, and is not working for the case 2 above.Describe the solution you'd like
I am wondering if Rosetta can add one more API, like
/account/info
:The
type
field is not in themetadata
for it's not optional.The text was updated successfully, but these errors were encountered: