Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion to remove confusion regarding periodograms #72

Open
goznalo-git opened this issue May 6, 2021 · 1 comment
Open

A suggestion to remove confusion regarding periodograms #72

goznalo-git opened this issue May 6, 2021 · 1 comment
Labels

Comments

@goznalo-git
Copy link

Hi there,
I've been recently reading about this Python library, because I needed to plot some periodograms. And it has proven to be a very frustrating experience. At first glance it seemed that WelchPeriodogram was a class, just like Periodogram itself. The same goes for DaniellPeriodogram. That caused me quite a lot of confusion until I read the souce code. And at least DaniellPeriodogram does have a class one can call, pdaniell, why not WelchPeriodogram? What am I missing?

Thank you for your effort though!

@cokelaer
Copy link
Owner

cokelaer commented Mar 1, 2022

@goznalo-git sorry for the confusion, I have developed spectrum a long time ago and my choice at that may not have been the best. The OOP was definitely a good choice but the user interface not. Since it is usde by quite a lot of users, I will probably keep it it this way for now for all back compatibities. I'll be happy to discuss more about it tough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants