-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive Site Navigation #69
Comments
Just realised ive not specifed where the code should be placed. |
hi |
hey @Arxhtects thanks for putting that together - was that just a mockup or did you make a proof of concept somewhere? id be curious to see an example of how that would look when it's not open for instance |
Hey it was a proof of concept from the inspect window. and the x button was just a quick paint job. Tbh making a toggle button is easy, i normaly do it with a div as a wrapper and 3 divs or spans inside. Some people do it with one div and before and afters, but i don't like doing it that way, I'm currently swamped work wise if i had time i would have forked and made a working concept, Maybe if i get some time ill make something, but tbh any one could pick this up and work from the code ive roughly put to geather. A simple Its just a basic of canvas menu. just put the code
into the element style and you will see it, all it would need is a media tag [mobile first, for that tasty google rankings] on the ul for it to change between resolutions :) |
@Arxhtects I would like to pick it up and work with the ground work you have laid. |
I have no issue with that 👍 |
as long as @Arxhtects didn't want to do the work and submit the PR that sounds good when working through it we'll want to make sure that we're providing a good experience for both mobile and desktop :) |
@allenjamesvinoy14 - let me know if you'd like any support with this. :) |
Hey, if this issue is still relevant, I'd like to work on this. |
@Ambareen09 sure that would be great! let me know if you have any questions |
Can you please help me with setting up the WORDPRESS_GRAPHQL_ENDPOINT? I am unable to follow the documentation for this part. |
you could try using a local wordpress instance: https://localwp.com/ there's also a service to spin up a temporary one but i can't find it right now, ill comment back if i find it |
I'm happy with the "desktop" experience for larger devices, but I didn't put a ton of thought into how mobile should look.
We should figure out a good way to present the navigation for all device sizes.
Things to consider:
A solution should be proposed before this Issue gets picked up to get worked on, ideally with a design mockup of sorts (doesn't need to be perfect for the mockup)
The text was updated successfully, but these errors were encountered: