From b876536c5db48deb156aac2b47bb5e89cf376b26 Mon Sep 17 00:00:00 2001 From: demeritcowboy Date: Sun, 8 Sep 2024 22:10:50 -0400 Subject: [PATCH 1/2] no longer need to create ufmatch --- .../WebformCivicrmTestBase.php | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php b/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php index 518bb38e7..311ea05da 100644 --- a/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php +++ b/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php @@ -98,13 +98,18 @@ protected function setUp(): void { 'id' => 'civicrm_webform_test', 'title' => 'CiviCRM Webform Test.' . $CiviCRM_version, ]); - $this->rootUserCid = $this->createIndividual()['id']; - // Create CiviCRM contact for rootUser. - $this->utils->wf_civicrm_api('UFMatch', 'create', [ - 'uf_id' => $this->rootUser->id(), - 'uf_name' => $this->rootUser->getAccountName(), - 'contact_id' => $this->rootUserCid, - ]); + if (version_compare(\CRM_Core_BAO_Domain::version(), '5.79.alpha1', '<')) { + $this->rootUserCid = $this->createIndividual()['id']; + // Create CiviCRM contact for rootUser. + $this->utils->wf_civicrm_api('UFMatch', 'create', [ + 'uf_id' => $this->rootUser->id(), + 'uf_name' => $this->rootUser->getAccountName(), + 'contact_id' => $this->rootUserCid, + ]); + } + else { + $this->rootUserCid = $this->getUFMatchRecord($this->rootUser->id())['contact_id']; + } } protected function tearDown(): void { From 6c92d2104b925bbe5bd2ab542bb0bf7517a19040 Mon Sep 17 00:00:00 2001 From: demeritcowboy Date: Mon, 9 Sep 2024 10:31:19 -0400 Subject: [PATCH 2/2] don't assume contact id is always 2 --- tests/src/FunctionalJavascript/MembershipSubmissionTest.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php index c3b23596f..80ed86b95 100644 --- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php +++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php @@ -122,11 +122,12 @@ public function testSubmitWebform() { $this->saveCiviCRMSettings(); + $adminUserCid = $this->getUFMatchRecord($this->adminUser->id())['contact_id']; // Create two memberships with the same status with the first membership // having an end date after the second membership's end date. $this->utils->wf_civicrm_api('membership', 'create', [ 'membership_type_id' => 'Basic', - 'contact_id' => 2, + 'contact_id' => $adminUserCid, 'join_date' => '08/10/21', 'start_date' => '08/10/21', 'end_date' => '08/10/22', @@ -136,7 +137,7 @@ public function testSubmitWebform() { $this->utils->wf_civicrm_api('membership', 'create', [ 'membership_type_id' => 'Basic', - 'contact_id' => 2, + 'contact_id' => $adminUserCid, 'join_date' => '01/01/21', 'start_date' => '01/01/21', 'end_date' => '01/01/22',