Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdatomic.h - missing? #110

Open
Yutanix opened this issue Apr 18, 2023 · 6 comments
Open

stdatomic.h - missing? #110

Yutanix opened this issue Apr 18, 2023 · 6 comments

Comments

@Yutanix
Copy link

Yutanix commented Apr 18, 2023

I get to the "make" step after "./configure", but then get countless errors regarding a file called "stdatomic.h" that is supposed to be in /Include/mimalloc/
ive tried the new nogil source, and still have the same problem with that file missing.

@colesbury
Copy link
Owner

stdatomic.h is a C header file provided by the C standard library. What compiler are you using? What operating system?

@Yutanix
Copy link
Author

Yutanix commented Apr 18, 2023

the "make" cmd to compile everything, and im on a Cent OS 7.8 box.

@colesbury
Copy link
Owner

Thanks. On CentOS make is probably using GCC as the compiler (unless you've changed the default compiler.) What version of gcc do you have? Can you run gcc --version and let me know the output?

@Yutanix
Copy link
Author

Yutanix commented Apr 18, 2023

gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)

@colesbury
Copy link
Owner

I guess there's a build problem with GCC 4.8.5. I can fix that, but it'll probably be a few days before I get to it. In the meantime you can download a pre-built version or install and use a newer version of GCC.

There's a pre-built version for Linux at https://github.com/colesbury/nogil/releases. You can download and use it with the following commands:

curl -L https://github.com/colesbury/nogil/releases/download/v3.9.10-nogil-2023-04-01/python-3.9.10-nogil-linux.tar.gz -o python-3.9.10-nogil-linux.tar.gz
tar xf python-3.9.10-nogil-linux.tar.gz
cd python-3.9.10-nogil-linux/bin
export PATH=`pwd`:$PATH

(Or you can move the python-3.9.10-nogil-linux directory to wherever you want. Just make sure you add the python-3.9.10-nogil-linux/bin directory to your path.)

@colesbury
Copy link
Owner

Hi @Yutanix, sorry for the delay. After looking into it, the issues appears to be that mimalloc doesn't support GCC 4.8. At this point, I want to avoid diverging further from upstream mimalloc, so I don't plan to fix that.

To use nogil Python, you can either use the pre-built binary (linked above) or install a newer version of GCC (or Clang).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants