-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicating results #96
Comments
Hi, regarding the experiments, we have fed in the ground truth intrinsic, so that intrinsics are properly shared among images, and are initialized with nice values. Also, we use undistorted images, instead of raw ones. Have you obtained reasonable values for COLMAP as a starting point? |
That was the point! Thanks. Now I get mostly the same scores as in the paper. It's interesting that in some scenes I get better results (for both models) than the GLOMAP paper. Also, at least in one run I did, GLOMAP does not fail on exhibition hall and scores 84.6 AUC while COLMAP 84.5 (starting from the same database). Also old computer scores better on my run of GLOMAP while the COLMAP run it's the same of yours. If you are interest we can discuss about it. Thanks again! |
@mattiadurso Great that you managed to replicate our experiments. Some smaller bugs have been fixed since submission of the paper and some components of the pipeline have been improved. So, it is expected that the latest commits in the main branch will produce slightly different (hopefully always better :-)) results than reported in the paper. The same goes for COLMAP. |
Hi @mattiadurso, great to hear that you reproduce the result. Just an additional note, the major difference between the current version and the result in the paper should be the initialization of rotation averaging. Now, I enabled initialization from the maximum spanning tree, which solved the problem for |
Thanks a lot for answering me! Hope to meet you at ECCV next week! |
hi would you mind sharing the colmap feature extractor command you used to populate the intrinsics with gt? I have so far failed to reproduce the numbers in Table 3. More strangely, for [electro, kicker, lounge] the number of images in glomap output As an example, these are the steps I took on "lounge".
I am using the cam parameter numbers in In the resulting |
If the intrinsics changes after you ran the model, try is to set the intrinsics equal within the same folder and divided the images in folders according to the intrinsics. Tell the model to do not refine the intrinsics during BA. If the final model has less images than in the original folder, it may have failed to register them. |
Thanks for your help @mattiadurso |
@lpanaf Thanks for giving us glomap. Do you mind providing more details on reproducing the results? |
Hi @w-hc, sorry for the late reply. I checked my result, and indeed, for electro and lounge, not all images are registered. You can also see in the table in the paper that the AUC @ 5 are below 90 for these two scenes (the error for the not estimated images are 180 degrees for every neighbor). For kicker, however, all images are correctly registered. |
@w-hc As for the command for creating the database, what I did is that I extract features with |
I also did this, but with the gui I get for scene (all images, registered)
|
Thanks @mattiadurso for replying. I got exactly the same number as this :) |
Thanks I'm able to roughly match the numbers. |
@lpanaf except that on 'meadow', glomap with gt intrinsics completely fails for some reason. The AUC is basically 0. I am using the latest commit. I notice the norms of the pose locations are close to 0. |
Following the discussions in #74 and #67, I ran COLMAP and GLOMAP on the (distorted) ETH3D MVS (DSLR) dataset. However, I’m struggling to reproduce your results and am encountering two main issues:
Since I’m using the AUC function directly from PxSfm (as mentioned in #67), I’m wondering if you tested the models with any non-default parameters. Some potential factors I’ve considered include:
Any insight or advice on how to address these issues would be greatly appreciated.
Thank you for your time.
The text was updated successfully, but these errors were encountered: