From 458ab834537ea0d11d613546b57ebb5d702e2f08 Mon Sep 17 00:00:00 2001
From: Bas Doppen <basdoppen@gmail.com>
Date: Fri, 28 Jun 2024 08:39:35 +0200
Subject: [PATCH 1/3] page header more compact

---
 .../src/app/[locale]/objects/[id]/gallery.tsx |  2 +-
 .../src/app/[locale]/objects/[id]/page.tsx    | 34 +++++++++----------
 2 files changed, 17 insertions(+), 19 deletions(-)

diff --git a/apps/researcher/src/app/[locale]/objects/[id]/gallery.tsx b/apps/researcher/src/app/[locale]/objects/[id]/gallery.tsx
index 931a256d3..b3c2754f3 100644
--- a/apps/researcher/src/app/[locale]/objects/[id]/gallery.tsx
+++ b/apps/researcher/src/app/[locale]/objects/[id]/gallery.tsx
@@ -84,7 +84,7 @@ export default function Gallery({images, organizationName}: Props) {
       </Tab.Panels>
 
       {images.length > 1 && (
-        <Tab.List className="w-1/2 md:w-full grid grid-cols-2 md:flex md:flex-row md:flex-wrap md:items-end gap-2 md:py-2 md:border-y-4 border-white">
+        <Tab.List className="w-1/2 md:w-full grid grid-cols-2 md:flex md:flex-row md:flex-wrap md:items-end gap-2 md:py-2">
           {images.map(image => (
             <Tab
               as="div"
diff --git a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
index 419993cb9..875931ff9 100644
--- a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
+++ b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
@@ -80,7 +80,7 @@ export default async function Details({params}: Props) {
             </div>
           </div>
 
-          <div className="w-full px-4 sm:px-10 max-w-[1800px] mx-auto py-10 md:pt-10 md:pb-20 xt:py-35 xl:pb-40 flex flex-col lg:flex-row gap-10">
+          <div className="w-full px-4 sm:px-10 max-w-[1800px] mx-auto flex flex-col lg:flex-row gap-4 xl:gap-10 py-4">
             <div className="w-full lg:w-2/3 xl:w-3/4">
               <div className="text-sm text-consortium-blue-100 mb-4 lg:mb-10 flex gap-1">
                 <ObjectIcon className='w-5 h-5 stroke-consortium-blue-100"' />
@@ -108,21 +108,19 @@ export default async function Details({params}: Props) {
                   </div>
                 ))}
               </div>
-            </div>
-
-            <div className="w-full lg:w-1/3 xl:w-1/4 text-sm text-consortium-blue-100 lg:pt-16">
-              {organization && (
-                <>
-                  <div className="italic">{t('providerCurrentHolder')}</div>
-                  <div className="text-white">{organization.name}</div>
-                  <div className="mb-4">
-                    {organization.address?.addressLocality}
-                  </div>
-                  <a href="#provider" className="p-4 -ml-4 italic" tabIndex={0}>
-                    {t('providerInfo')}
-                  </a>
-                </>
-              )}
+              <div className="text-sm my-4 xl:my-10 text-consortium-blue-100">
+                {organization && (
+                  <>
+                    Data provider or current object holder:{' '}
+                    <span className="text-white">
+                      <a href="#dataprovider" className="underline">
+                        {organization.name}
+                      </a>
+                    </span>
+                    , {organization.address?.addressLocality}
+                  </>
+                )}
+              </div>
             </div>
           </div>
         </div>
@@ -217,9 +215,9 @@ export default async function Details({params}: Props) {
             </div>
             <LocalContextsNotices />
           </main>
-          <aside className="w-full md:w-1/3 self-stretch order-1 md:order-2  md:mx-0 md:bg-neutral-100 p-1">
+          <aside className="w-full lg:w-1/3 self-stretch flex flex-col justify-start order-1 lg:order-2">
             {galleryImages.length > 0 && (
-              <div className="flex flex-row md:flex-col gap-1 sticky top-4">
+              <div className="flex flex-row md:flex-col gap-1 sticky top-8 lg:-mt-72 z-30 md:mx-0 p-4 rounded bg-consortium-blue-400/10">
                 <Gallery
                   images={galleryImages}
                   organizationName={organization?.name}

From 81ceaed70deaa342fb043faeb69d83591edf0999 Mon Sep 17 00:00:00 2001
From: Bas Doppen <basdoppen@gmail.com>
Date: Fri, 28 Jun 2024 08:54:13 +0200
Subject: [PATCH 2/3] translations aria

---
 .../src/app/[locale]/objects/[id]/page.tsx           | 12 +++++++++---
 apps/researcher/src/messages/en/messages.json        |  1 +
 apps/researcher/src/messages/nl/messages.json        |  1 +
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
index 875931ff9..249f006b0 100644
--- a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
+++ b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
@@ -3,6 +3,7 @@ import heritageObjects from '@/lib/heritage-objects-instance';
 import Gallery from './gallery';
 import ToFilteredListButton from '@/components/to-filtered-list-button';
 import {ChevronLeftIcon} from '@heroicons/react/24/solid';
+import {InformationCircleIcon} from '@heroicons/react/24/outline';
 import {ObjectIcon} from '@/components/icons';
 import {Metadata} from './metadata';
 import {decodeRouteSegment} from '@/lib/clerk-route-segment-transformer';
@@ -108,13 +109,18 @@ export default async function Details({params}: Props) {
                   </div>
                 ))}
               </div>
-              <div className="text-sm my-4 xl:my-10 text-consortium-blue-100">
+              <div className="text-sm my-4 xl:my-10 text-consortium-blue-100 flex gap-1">
                 {organization && (
                   <>
-                    Data provider or current object holder:{' '}
+                    {t('providerCurrentHolder')}
                     <span className="text-white">
-                      <a href="#dataprovider" className="underline">
+                      <a
+                        href="#dataprovider"
+                        className="underline inline-flex gap-1 items-center"
+                        aria-label={t('providerCurrentHolder')}
+                      >
                         {organization.name}
+                        <InformationCircleIcon className="w-4 h-4 stroke-white" />
                       </a>
                     </span>
                     , {organization.address?.addressLocality}
diff --git a/apps/researcher/src/messages/en/messages.json b/apps/researcher/src/messages/en/messages.json
index a935251b1..7d4893e1d 100644
--- a/apps/researcher/src/messages/en/messages.json
+++ b/apps/researcher/src/messages/en/messages.json
@@ -102,6 +102,7 @@
     "noEntity": "Object could not be found",
     "object": "Object",
     "providerCurrentHolder": "Data provider object",
+    "accessibilityProviderCurrentHolder": "More information about the data provider",
     "providerInfo": "More info",
     "contactInfo": "Contact info",
     "dataProviderTitle": "Data provider object",
diff --git a/apps/researcher/src/messages/nl/messages.json b/apps/researcher/src/messages/nl/messages.json
index 6d19dd223..a8d502f3e 100644
--- a/apps/researcher/src/messages/nl/messages.json
+++ b/apps/researcher/src/messages/nl/messages.json
@@ -102,6 +102,7 @@
     "noEntity": "Object kon niet gevonden worden",
     "object": "Object",
     "providerCurrentHolder": "Data provider of huidig object bewaarder",
+    "accessibilityProviderCurrentHolder": "Meer informatie over de data provider of huidig object bewaarder",
     "providerInfo": "Meer info",
     "contactInfo": "Contact gegevens",
     "dataProviderTitle": "Data provider of huidig object bewaarder",

From a97d1e032105aaacd0f13d7c739a8bee55623a88 Mon Sep 17 00:00:00 2001
From: Bas Doppen <basdoppen@gmail.com>
Date: Fri, 28 Jun 2024 08:56:24 +0200
Subject: [PATCH 3/3] responsive on mobile

---
 apps/researcher/src/app/[locale]/objects/[id]/page.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
index 249f006b0..8c3f6e0c6 100644
--- a/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
+++ b/apps/researcher/src/app/[locale]/objects/[id]/page.tsx
@@ -109,7 +109,7 @@ export default async function Details({params}: Props) {
                   </div>
                 ))}
               </div>
-              <div className="text-sm my-4 xl:my-10 text-consortium-blue-100 flex gap-1">
+              <div className="text-sm my-4 xl:my-10 text-consortium-blue-100 md:flex gap-1">
                 {organization && (
                   <>
                     {t('providerCurrentHolder')}