Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a proper error type from set_virtual_terminal #155

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

Return a proper error type from set_virtual_terminal #155

wants to merge 2 commits into from

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Dec 11, 2023 •
edited
Loading

Follow-up to #105. This is a breaking change.

@kurtlawrence kurtlawrence added the breaking Will need a major version bump label Dec 11, 2023
@kurtlawrence
Copy link
Collaborator

I've made a v3 branch for breaking changes. Could you please target the PR towards that branch?

@madsmtm madsmtm changed the base branch from master to v3 December 12, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtlawrence kurtlawrence kurtlawrence approved these changes

Assignees
No one assigned
Labels
breaking Will need a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @kurtlawrence