Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the size of .bsp/mill-bsp.stderr #2199

Open
lefou opened this issue Dec 16, 2022 · 5 comments
Open

Limit the size of .bsp/mill-bsp.stderr #2199

lefou opened this issue Dec 16, 2022 · 5 comments
Labels
good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.

Comments

@lefou
Copy link
Member

lefou commented Dec 16, 2022

Currently, this file is growing unlimited, which can become an issue if disc space gets low.
@lefou lefou added the good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies. label Dec 19, 2022
@seroperson
Copy link
Contributor

I think it should be implemented like some kind of log rotation with specifying somewhere (or just harcoding) values like logMaxSize, logFileLimit. There are a lot of examples of such problem (the first one which I googled: link) and looks like we should implement something like this.

@lefou
Copy link
Member Author

lefou commented Dec 22, 2022 •
edited
Loading

Yeah, log-rotation might be nice. This topic seems simple and very common, yet it provides lots of ways to shot yourself in the foot. Especially, as we target different platforms including Windows, which provides lots of stumbling blocks like file locking. Using some small proven library is probably a good idea.

@seroperson
Copy link
Contributor

seroperson commented Dec 24, 2022 •
edited
Loading

rotating-fos looks suitable here, it provides just some extensible OutputStream. I will try to implement it in near time.

@gamlerhart
Copy link
Contributor

I think this file is not generated anymore? At least I don't see it since Mill 0.12?

@lefou
Copy link
Member Author

lefou commented Jan 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue The fix/solution for the issue is considered easy. A good starting point for newbies.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gamlerhart @lefou @seroperson