Redundant Outer Loop and Potential Bug in get_images Function

[2ndpic]

Link to the code

for o in history['outputs']:
    for node_id in history['outputs']:
        node_output = history['outputs'][node_id]
        if 'images' in node_output:
            images_output = []
            for image in node_output['images']:
                image_data = get_image(image['filename'], image['subfolder'], image['type'])
                images_output.append(image_data)
        output_images[node_id] = images_output

First, I believe the outer loop for o in history['outputs']: is redundant and can be removed. This loop seems to serve no practical purpose as it merely iterates over the length of history['outputs'] without performing any operations on each element.

Secondly, I think images_output = [] should be placed above the condition if 'images' in node_output:. The current code structure will result in an error local variable 'images_output' referenced before assignment when the if condition is false.

Can the author or community members explain if there are any additional considerations for this code, or if it was simply written in error? Thank you!

Suggested modification:

for node_id in history['outputs']:
    node_output = history['outputs'][node_id]
    images_output = []  # Initialize images_output here
    if 'images' in node_output:
        for image in node_output['images']:
            image_data = get_image(image['filename'], image['subfolder'], image['type'])
            images_output.append(image_data)
    output_images[node_id] = images_output

[ltdrdata]

I made a PR for this.
#4656