Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldDefinition.type should point to FieldType instead of object #35

Open
mvantellingen opened this issue Dec 10, 2018 · 1 comment
Open

FieldDefinition.type should point to FieldType instead of object #35

mvantellingen opened this issue Dec 10, 2018 · 1 comment

Comments

@mvantellingen
Copy link
Contributor

I also ran into the following issue: the FieldDefinition.type points to object instead of FieldType. This makes serializing/deserializing with auto generated code impossible.

See

commercetools-api-reference/types/type/FieldDefinition.raml

Line 10 in 5b98b89

type: object # FieldType # ToDO: fix when discriminators are correctly resolved

According to the file it is an TODO item. Changing this in the file on our end makes things work.
@jenschude
Copy link
Contributor

Oh yeah. I would have to check this again. At the point were I wrote this not the whole tool chain could work correctly with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvantellingen @jenschude