Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal component and scroll event #1878

Open
gabriele-ct opened this issue Nov 27, 2023 · 0 comments
Open

Modal component and scroll event #1878

gabriele-ct opened this issue Nov 27, 2023 · 0 comments
Assignees
Labels
🚀 Status: Groomed All is known to start development 🐛 Type: Bug Something isn't working

Comments

@gabriele-ct
Copy link
Contributor

gabriele-ct commented Nov 27, 2023

The modal component provided by docs-kit, which is an almost 1:1 porting of the one provided in the MC ui-kit has a possible issue with the scrolling event.

If there is no component to scroll within the modal, the scroll event seems to propagate to the backgorund page (the page covered by the modal dark overlay).

This issue can be easily reproduced by opening the AI chat modal and trying to scroll when the modal is opened.

Requirements:

  • when a modal is opened, the scroll event (both mouse wheel and mobile) should affect only the modal and not propagate to the background layer.
  • The scroll functionality should still work as usual if any scrollable elements are displayed in the modal
@FFawzy FFawzy added 🐛 Type: Bug Something isn't working 🚀 Status: Groomed All is known to start development labels Jan 25, 2024
@gabriele-ct gabriele-ct self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: Groomed All is known to start development 🐛 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants