From c908b52fe1c44dac5218d98bcd74affd446353f0 Mon Sep 17 00:00:00 2001
From: Rui Pedro Dias <rui.dias@commercetools.com>
Date: Wed, 10 Jul 2024 12:28:13 +0100
Subject: [PATCH] fix(templates): fix node version and minor fixes

---
 .eslintignore                                         | 1 +
 .nvmrc                                                | 2 +-
 application-templates/javascript/assets/.eslintrc.cjs | 7 +++----
 application-templates/javascript/event/.nvmrc         | 2 +-
 application-templates/javascript/job/.nvmrc           | 2 +-
 application-templates/javascript/service/.nvmrc       | 2 +-
 application-templates/typescript/event/.nvmrc         | 2 +-
 application-templates/typescript/job/.nvmrc           | 2 +-
 application-templates/typescript/service/.nvmrc       | 2 +-
 packages/create-connect-app/.nvmrc                    | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.eslintignore b/.eslintignore
index cb297d1..bf38cca 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -2,4 +2,5 @@ node_modules
 packages/create-connect-app/build
 application-templates/typescript/*/build
 application-templates/typescript/*/public
+application-templates/javascript/*/public
 .nvmrc
\ No newline at end of file
diff --git a/.nvmrc b/.nvmrc
index 0ff3804..78a9495 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/application-templates/javascript/assets/.eslintrc.cjs b/application-templates/javascript/assets/.eslintrc.cjs
index 006123c..8084aa1 100644
--- a/application-templates/javascript/assets/.eslintrc.cjs
+++ b/application-templates/javascript/assets/.eslintrc.cjs
@@ -1,13 +1,12 @@
 module.exports = {
   root: true,
-  parser: '@typescript-eslint/parser',
+  extends: ['eslint:recommended'],
   parserOptions: {
     ecmaVersion: 2020,
+    sourceType: 'module',
   },
-  plugins: ['@typescript-eslint'],
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended'],
   rules: {
-    '@typescript-eslint/no-unused-vars': 'error',
+    'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     'no-undef': 'error',
     'no-console': 'error',
     'no-const-assign': 'error',
diff --git a/application-templates/javascript/event/.nvmrc b/application-templates/javascript/event/.nvmrc
index 0ff3804..78a9495 100644
--- a/application-templates/javascript/event/.nvmrc
+++ b/application-templates/javascript/event/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/application-templates/javascript/job/.nvmrc b/application-templates/javascript/job/.nvmrc
index 0ff3804..78a9495 100644
--- a/application-templates/javascript/job/.nvmrc
+++ b/application-templates/javascript/job/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/application-templates/javascript/service/.nvmrc b/application-templates/javascript/service/.nvmrc
index 0ff3804..78a9495 100644
--- a/application-templates/javascript/service/.nvmrc
+++ b/application-templates/javascript/service/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/application-templates/typescript/event/.nvmrc b/application-templates/typescript/event/.nvmrc
index 431076a..1efe0ac 100644
--- a/application-templates/typescript/event/.nvmrc
+++ b/application-templates/typescript/event/.nvmrc
@@ -1 +1 @@
-16.16.0
+v20.15.1
diff --git a/application-templates/typescript/job/.nvmrc b/application-templates/typescript/job/.nvmrc
index 0ff3804..78a9495 100644
--- a/application-templates/typescript/job/.nvmrc
+++ b/application-templates/typescript/job/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/application-templates/typescript/service/.nvmrc b/application-templates/typescript/service/.nvmrc
index 0ff3804..78a9495 100644
--- a/application-templates/typescript/service/.nvmrc
+++ b/application-templates/typescript/service/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file
diff --git a/packages/create-connect-app/.nvmrc b/packages/create-connect-app/.nvmrc
index 0ff3804..78a9495 100644
--- a/packages/create-connect-app/.nvmrc
+++ b/packages/create-connect-app/.nvmrc
@@ -1 +1 @@
-16.16.0
\ No newline at end of file
+v20.15.1
\ No newline at end of file