Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEC-138] Improve js components migration #3682

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

Improve js components migration

Description

I discovered another use case we were not covering: when we have a React component in a Javascript file and it does not have already destructured properties in the function declaration.

import * as PropTypes from 'prop-types';

function MyComponent(props) {
  return <div>{props.foo}</div>;
}
MyComponent.defaultProps = {
  foo: 'bar',
};
MyComponent.propTypes = {
  foo: PropTypes.string,
};

@CarlosCortizasCT CarlosCortizasCT added the fe-chapter-rotation Tasks coming from frontend chapter work label Dec 20, 2024
@CarlosCortizasCT CarlosCortizasCT self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: d9d281a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:53am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:53am

Copy link
Contributor

@mmaltsev-ct mmaltsev-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarlosCortizasCT CarlosCortizasCT merged commit d6f5849 into main Dec 23, 2024
17 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the fec-128-adjust-js-components branch December 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants