Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happy-2.0 #7520

Closed
2 tasks
mihaimaruseac opened this issue Sep 20, 2024 · 14 comments · Fixed by #7521
Closed
2 tasks

happy-2.0 #7520

mihaimaruseac opened this issue Sep 20, 2024 · 14 comments · Fixed by #7521

Comments

@mihaimaruseac
Copy link
Contributor

happy-2.0 (changelog) (Andreas Abel [email protected] @andreasabel) is out of bounds for:

happy-lib (not present) depended on by:

Will place an upper bound on happy

mihaimaruseac added a commit that referenced this issue Sep 20, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
@andreasabel
Copy link
Contributor

@sgraf812 : Looks like happy-lib needs now to be added Stackage.
Do you wish to take over Stackage maintainership of happy?
Basically means you would be pinged in such cases instead of me...

@sgraf812
Copy link
Contributor

Can do!

@andreasabel
Copy link
Contributor

andreasabel commented Sep 20, 2024

Thanks! That means in practice that you add yourself to the build-constraints.yaml file in a PR and move this line to under your name:

- happy < 1.21.0 # Note, cannot use 1.21.0, and 2.0 blocked by https://github.com/commercialhaskell/stackage/issues/7520

(And of course add a line for happy-lib.)

@andreasabel
Copy link
Contributor

andreasabel commented Sep 20, 2024

@sgraf812 I saw your commit, thanks!
Probably you need to keep the bound happy < 1.21 for now until config-value (@juhp) allows happy-2.0.

@sgraf812
Copy link
Contributor

until config-value (@juhp) allows happy-2.0.

I trust that the stackage curators know what that means and remove the upper bound again(?)

Does stackage understand deprecated versions? I'm going to deprecate 2.0 in favour of 2.0.1 due to haskell/happy#303.

@andreasabel
Copy link
Contributor

until config-value (@juhp) allows happy-2.0.

I trust that the stackage curators know what that means and remove the upper bound again(?)

Yes, they will when they can close this issue.

Does stackage understand deprecated versions? I'm going to deprecate 2.0 in favour of 2.0.1 due to haskell/happy#303.

Stackage only has a single version of each package per snapshot, and by default the latest versions enter the nightly snapshot. So, once the bound <1.21 is removed, the latest enters, which is then 2.0.1 and no longer 2.0.

mihaimaruseac added a commit that referenced this issue Sep 20, 2024
Move maintenance of `happy` and `happy-lib` to @sgraf812 (#7520)
@andreasabel
Copy link
Contributor

I think this issue is only fixed after removing the happy bound, so I guess it should be opened again.

@mihaimaruseac
Copy link
Contributor Author

That's true, reopening

@mihaimaruseac mihaimaruseac reopened this Sep 20, 2024
@juhp
Copy link
Contributor

juhp commented Sep 21, 2024

Okay it's "just me" hm: so actually config-value is not my package at all, I just added it to get copilot into Stackage...

@glguy actually made a commit yesterday already: glguy/config-value@a5f7f92 so I guess we just need to wait or poke him for a release.

juhp added a commit that referenced this issue Sep 21, 2024
@sgraf812
Copy link
Contributor

FWIW, we aren't in a rush here. I don't think anyone is waiting for happy 2.0. I was just wondering if some step in the process was blocked on me without knowing

@glguy
Copy link
Contributor

glguy commented Sep 21, 2024

I updated the bound on hackage

@mihaimaruseac
Copy link
Contributor Author

I think now we are blocked on Sit and haskell-src which both use happy as build-tools. @andreasabel I think these are on your side?

@andreasabel
Copy link
Contributor

andreasabel commented Sep 22, 2024

I think now we are blocked on Sit and haskell-src which both use happy as build-tools.

Fixed by haskell-src-1.0.4.1 and Sit-0.2023.8.3@rev:1.

@mihaimaruseac
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants