Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yesod-core-1.6.26.0 doesn't compile with wai-extra-3.1.17 #7570

Open
mihaimaruseac opened this issue Nov 7, 2024 · 0 comments
Open

yesod-core-1.6.26.0 doesn't compile with wai-extra-3.1.17 #7570

mihaimaruseac opened this issue Nov 7, 2024 · 0 comments

Comments

@mihaimaruseac
Copy link
Contributor

       /home/curators/work/unpack-dir/unpacked/yesod-core-1.6.26.0-4ef96b72964ccfbbb2caa68f02f513fd41f98d4d836357fa358716c844b97efa/src/Yesod/Core/Dispatch.hs:247:32: error: [GHC-83865]
           • Couldn't match expected type ‘GzipSettings’
                         with actual type ‘RequestLoggerSettings’
           • In a record update at fields ‘destination’, ‘outputFormat’,
             with type constructor ‘RequestLoggerSettings’
             and data constructor ‘Network.Wai.Middleware.RequestLogger.RequestLoggerSettings’.
             In the first argument of ‘mkRequestLogger’, namely
               ‘def
                  {destination = Network.Wai.Middleware.RequestLogger.Logger
                                   $ loggerSet logger,
                   outputFormat = Apache FromSocket}’
             In a stmt of a 'do' block:
               logWare <- mkRequestLogger
                            def
                              {destination = Network.Wai.Middleware.RequestLogger.Logger
                                               $ loggerSet logger,
                               outputFormat = Apache FromSocket}
           |
       247 |     logWare <- mkRequestLogger def
           |                                ^^^...

Will place an upper bound on wai-extra for now since a new version was just released.

CC @snoyberg

PS: Should we move yesod-core to a maintained status? Right now it's just grandfathered

mihaimaruseac added a commit that referenced this issue Nov 7, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
mihaimaruseac added a commit to commercialhaskell/lts-haskell that referenced this issue Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant