-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change signed download functionality to use CF instead of S3 #57
Comments
Are those env variables used in the node implementation available in project? |
No, they would need to be added in the kubernetes manifests. See: https://github.com/commitdev/zero-backend-node/blob/1376ac0e7ff4448d641633c0ff69f602acbeebf4/templates/kubernetes/overlays/staging/kustomization.yml#L27 for the staging one |
I'm a bit lost sorry. Refering to the cloudfront env variables used here |
Ah, right. Those are supplied as secrets, defined here. |
Alright so I can assume they exist and go on with implementing the go version of the node implementation? |
You could just copy that section right over from the kubernetes manifests in the node project and it should work fine. |
This feature should be using Cloudfront for downloads instead of S3. See the node backend implementation.
The text was updated successfully, but these errors were encountered: