Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signed download functionality to use CF instead of S3 #57

Open
bmonkman opened this issue Mar 3, 2021 · 6 comments
Open

Change signed download functionality to use CF instead of S3 #57

bmonkman opened this issue Mar 3, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@bmonkman
Copy link
Contributor

bmonkman commented Mar 3, 2021

This feature should be using Cloudfront for downloads instead of S3. See the node backend implementation.

@bmonkman bmonkman added the bug Something isn't working label Mar 3, 2021
@benjaminkvm benjaminkvm self-assigned this May 3, 2021
@deven96
Copy link
Contributor

deven96 commented Oct 25, 2021

Are those env variables used in the node implementation available in project?

@bmonkman
Copy link
Contributor Author

No, they would need to be added in the kubernetes manifests. See: https://github.com/commitdev/zero-backend-node/blob/1376ac0e7ff4448d641633c0ff69f602acbeebf4/templates/kubernetes/overlays/staging/kustomization.yml#L27 for the staging one

@deven96
Copy link
Contributor

deven96 commented Oct 25, 2021

I'm a bit lost sorry. Refering to the cloudfront env variables used here

@bmonkman
Copy link
Contributor Author

Ah, right. Those are supplied as secrets, defined here.
The secret will be created by the terraform if this is set to true.

@deven96
Copy link
Contributor

deven96 commented Oct 25, 2021

Alright so I can assume they exist and go on with implementing the go version of the node implementation?
Or does the kubernetes manifest still have some work? @bmonkman

@bmonkman
Copy link
Contributor Author

You could just copy that section right over from the kubernetes manifests in the node project and it should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants