You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am now serializing and deserializing the AST with a 1:1 exact match such that it could be converted to a JSON document and back to an AST tree.
The rationale for this functionality is that I want to pipe an AST document between processes and felt that parsing documents on the way in and rendering on the way out was too much overhead.
The implementation is two static methods Node.serialize() and Node.deserialize(), I would like it if possible to add these methods to the commonmark Node class.
The test specs serialize and deserialize have 100% coverage on those methods. Notably the deserialize spec ensures a 1:1 correlation with a deep equals comparison.
Note that we don't expose private properties in the serialized object so that iteration can consistently reference firstChild and next regardless of whether it is a full AST node (with parent references) or a detached serialized object.
During this process a few requests regarding public property access have arisen, could I please expose _lastLineBlank and _htmlBlockType with public getters?
Also at times I need to associate custom data with AST nodes and this has been a bit ad-hoc so far, hence the additional properties file etc. that I would like to tuck away in an object that commonmark Node supports, maybe userData or data?
If we can formalize a way to add custom data to nodes then I can update the serialize and deserialize methods to use that and it could be folded in to commonmark Node.
Thanks for all your help and patience - especially with those questions that deserved a RTFM response ;)
The text was updated successfully, but these errors were encountered:
I am now serializing and deserializing the AST with a 1:1 exact match such that it could be converted to a JSON document and back to an AST tree.
The rationale for this functionality is that I want to pipe an AST document between processes and felt that parsing documents on the way in and rendering on the way out was too much overhead.
The implementation is two static methods
Node.serialize()
andNode.deserialize()
, I would like it if possible to add these methods to the commonmarkNode
class.The code is here:
https://github.com/mkdoc/mkast/blob/aa0fa3c5bf4ca45e8c961ad14640543da60ec529/lib/node.js#L141-L355
The test specs serialize and deserialize have 100% coverage on those methods. Notably the deserialize spec ensures a 1:1 correlation with a deep equals comparison.
Note that we don't expose private properties in the serialized object so that iteration can consistently reference
firstChild
andnext
regardless of whether it is a full AST node (with parent references) or a detached serialized object.During this process a few requests regarding public property access have arisen, could I please expose
_lastLineBlank
and_htmlBlockType
with public getters?Also at times I need to associate custom data with AST nodes and this has been a bit ad-hoc so far, hence the additional properties
file
etc. that I would like to tuck away in an object that commonmarkNode
supports, maybeuserData
ordata
?If we can formalize a way to add custom data to nodes then I can update the
serialize
anddeserialize
methods to use that and it could be folded in to commonmarkNode
.Thanks for all your help and patience - especially with those questions that deserved a RTFM response ;)
The text was updated successfully, but these errors were encountered: