Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible g_free of invalid memory #1

Open
freemangordon opened this issue Apr 2, 2017 · 0 comments
Open

possible g_free of invalid memory #1

freemangordon opened this issue Apr 2, 2017 · 0 comments

Comments

@freemangordon
Copy link
Contributor

on https://github.com/community-ssu/libhildonfm/blob/master/hildon-fm/hildon-file-system-storage-dialog.c#L1166 total, available and in_use are declared as const gchar *. However, later on, those are passed to g_free. The problem is that we have a possible scenario - see https://github.com/community-ssu/libhildonfm/blob/master/hildon-fm/hildon-file-system-storage-dialog.c#L1268 where we try to g_free the results of dgettext, which is plain wrong.

I guess the fix should be to remove const modifier from variable declarations and to g_strdup dgettext results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freemangordon