Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User able to contribute without signing ICLA #4435

Open
mlehotskylf opened this issue Sep 3, 2024 · 4 comments
Open

User able to contribute without signing ICLA #4435

mlehotskylf opened this issue Sep 3, 2024 · 4 comments
Labels
bug Something isn't working internal Internal tickets

Comments

@mlehotskylf
Copy link
Contributor

mlehotskylf commented Sep 3, 2024

Issue:
User able to contribute without finishing signing ICLA even through it is required under CCLA flow.

Steps:

  1. Configure CLA Group with option Require corporate contributors to sign Individual CLAs
  2. Login as CLA manager and add contributor to "Approval List"
  3. Login as the same contributor and create PR
  4. You will not be "covered" so begin "signing" process as corporate contributor which will force you to sign ICLA
  5. Follow steps in "signing" process for ICLA but do NOT do final document sign in DocuSign and do NOT finish signing process

Expected:
Since contributor didn't do final sign in Docusign the he/she should not be able to contribute.

Actual:
Contributor is "covered" and is able to contribute

Screenshot 2024-09-02 at 5 30 51 PM

Also Acknowledged On date is "invalid" what also indicate that acknowledgement was not done but user has status "Authorized".

Screenshot 2024-09-02 at 5 45 00 PM

@mlehotskylf mlehotskylf added bug Something isn't working internal Internal tickets labels Sep 3, 2024
@mlehotskylf
Copy link
Contributor Author

mlehotskylf commented Sep 3, 2024

I see more users which are Authorized but has invalid Acknowledged On date. @thakurveerendras should we open separate issue for that?

Screenshot 2024-09-02 at 5 48 55 PM

@thakurveerendras
Copy link
Contributor

@mlehotskylf, Let me check original issue mentioned in ticket at description, It works fine on last run, need to confirm if there any invalid record at database which create this issue

We have separate ticket for invalid date use case, Refer id: #4264

@mlehotskylf
Copy link
Contributor Author

@thakurveerendras were you able to reproduce this issue?

@thakurveerendras
Copy link
Contributor

@mlehotskylf , It is still reproducible as reported
CC: @nickmango

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Internal tickets
Projects
None yet
Development

No branches or pull requests

3 participants