Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with Boost 1.78 and release candidate of CRAN package BH #40

Open
eddelbuettel opened this issue Dec 14, 2021 · 3 comments

Comments

@eddelbuettel
Copy link

Dear TDA team,

It is the time of the year when I attempt to update BH to the now current Boost version. Just like last year, the (somewhat complicated, kudos to you all) TDA package appears to be affected. See eddelbuettel/bh#80 for discussion and a mention of the release candidate of BH in the ghrr-drat (use install.packages("BH", repo="https://ghrr.github.io/drat") to install it).

Can I ask you to help out and take a look? I tried, but there is a lot of rather sophisticated code here so I didn't quite make it to a solution.

Let me know if I can help in any other way.

Thanks, and best regards, Dirk

@eddelbuettel
Copy link
Author

This release candidate is now on CRAN, and I hope I can count on you to adjust TDA as needed. Please let me know if I can help in any way.

@jkim82133
Copy link
Collaborator

Thank you for letting us know the issues. We will take a look and fix them.

Jisu KIM

@eddelbuettel
Copy link
Author

Thank you so much. This is what I hoped for, and expressed to CRAN, who concurred, given your very good track of keeping your package up, The new BH is by now on CRAN, but as CRAN closes soon for the rest of the year maybe you can work on it then.

If there is something I can do from my side in BH to help you with TDA please let me know. The 'once a year' and hence 'every three Boost releases' cadence seems to work out ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants