-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Dependabot to update Terraform module versions daily #60
base: main
Are you sure you want to change the base?
Conversation
|
||
- package-ecosystem: "terraform" | ||
directory: "terraform/groups/ecs-service" | ||
schedule: | ||
interval: "daily" | ||
versioning-strategy: "increase" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versioning-strategy
attribute isn't supported for the Terraform ecosystem so this can be removed, and a daily
frequency is likely to generate excessive pull requests—weekly
should suffice for these kind of updates.
You'll also need to introduce configuration for a registry to support Terraform updates for this project as it uses modules from a private terraform-modules GitHub repository here and here.
I would also recommend grouping updates (per package manager) as it can reduce the number of open pull requests and maintenance burden, generally making things easier to manage:
- package-ecosystem: "terraform" | |
directory: "terraform/groups/ecs-service" | |
schedule: | |
interval: "daily" | |
versioning-strategy: "increase" | |
- package-ecosystem: "terraform" | |
directory: "terraform/groups/ecs-service" | |
schedule: | |
interval: "weekly" | |
registries: | |
github-dependabot: | |
type: git | |
url: https://github.com | |
username: x-access-token | |
password: ${{secrets.DEPENDABOT_GITHUB_ACCESS_TOKEN}} | |
groups: | |
version-updates: | |
applies-to: "version-updates" | |
patterns: | |
- "*" | |
security-updates: | |
applies-to: "security-updates" | |
patterns: | |
- "*" |
This would require the introduction of a DEPENDABOT_GITHUB_ACCESS_TOKEN
Dependabot secret, either at the repository or organisation level. We've previously implemented this across several projects at the repository level (prior to the migration to GitHub Enterprise) but this would be best implemented as an organisation secret now.
The main issue with adopting Dependabot is the lack of ownership across projects in general—I can see from the existing configuration for the npm
ecosystem that updates aren't being merged, instead Dependabot is closing them and replacing them as newer versions of dependencies become available. It will eventually disable itself after a 90 day window if it goes unmaintained. This is something you'll want to escalate as we've already seen this in other projects where Dependabot pull requests are ignored and have no real meaningful value as a result.
Change description
try to leverage dependabot to update tf modules and put up a PR up
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:
introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:
andfeat:
are allowed, for examplebuild:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
, and others,BREAKING CHANGE: <description>
may be provided.