Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for multiple ingresses objects #16

Open
yahel2410 opened this issue Jun 28, 2023 · 4 comments
Open

Add option for multiple ingresses objects #16

yahel2410 opened this issue Jun 28, 2023 · 4 comments

Comments

@yahel2410
Copy link
Contributor

Hi, I have a use-case where I need to deploy 2 ingresses for the same service, with different annotations per each ingress.
In particular I'm trying the set nginx.ingress.kubernetes.io/auth-url for one ingress and don't set it for the other.

Can you please add support for multiple ingresses objects?

@p-afraz
Copy link
Member

p-afraz commented Jun 30, 2023

Hi, so is this what you suggest to be supported in the values file?

current:

ingress:
    enabled: true
    annotations:
        nginx.ingress.kubernetes.io/auth-url: http://test.com/foo

new:

ingress:
    - annotations:
           nginx.ingress.kubernetes.io/auth-url: http://test.com/foo
    - annotations:
           nginx.ingress.kubernetes.io/auth-url: http://test.com/bar

@yahel2410
Copy link
Contributor Author

Hey, yes something like that.
I suggest to accept a list of ingresses and create an Ingress object for each of them.
I my case the 2nd ingress doesn't need the auth-url annotation.

e.g:

current:

ingress:
  enabled: true
  path: /foo
  hostname: "a.example.com"
  ingressClassName: "nginx"
  annotations:
    nginx.ingress.kubernetes.io/auth-url: http://test.com/foo

new:

ingress:
  - enabled: true
    path: /foo
    hostname: "a.example.com"
    ingressClassName: "nginx"
    annotations:
      nginx.ingress.kubernetes.io/auth-url: http://test.com/foo
  - enabled: true
    path: /bar
    hostname: "a.example.com"
    ingressClassName: "nginx"

@yahel2410
Copy link
Contributor Author

@atkrad What do you think about this? I really need this since I currently have an ingress applied manually outside of the chart because of different annotations.

Maybe adding extraIngresses option will solve this? I can work on a PR

@denzhel
Copy link

denzhel commented Aug 15, 2023

I also need this, @atkrad What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants