Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config variable AWS_REGION now seems required #1892

Open
jucor opened this issue Jan 30, 2025 · 0 comments
Open

Config variable AWS_REGION now seems required #1892

jucor opened this issue Jan 30, 2025 · 0 comments
Assignees

Comments

@jucor
Copy link
Contributor

jucor commented Jan 30, 2025

Expected behavior:
Running with the default example.env (copied to .env) should allow to run polis.

Actual behavior:
When copying example.env to .env and running with make as per README.md, got an error complaining of an empty region, and the polis server not starting.

Setting:

AWS_REGION=us-east-1 
AWS_ACCESS_KEY_ID=dummy-key
AWS_SECRET_ACCESS_KEY=dummy-secret 

in .env then allowed the server to actually start.

Additional context:
I suspect this might be due to the new code that uses AWS DynamoDB to store the topics, and might not have a graceful fallback if no region is specified.

Since we still want polis to be runnable locally without AWS setup, I suggest one of two mitigations:

  • find where the graceful fallback is needed and add it, to support empty AWS_REGION :)
  • or at least modify example.env with a region, so polis still runs out of the box.

Further question:
This make me wonder: now that we seem to have a dependency on DynamoDB for the topics, do we have any other places that will break if someone has not set up their AWS in some specific way, or do we have a graceful fallback?
If not, should we document in the README what AWS setup is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants