Skip to content

Commit

Permalink
Ensuring that we don't tag Event:Rule
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnPreston committed Aug 15, 2023
1 parent 8b7763c commit 698dbc6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion ecs_composex/common/tagging.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from compose_x_common.compose_x_common import keyisset
from troposphere import Ref, Tags
from troposphere.ec2 import LaunchTemplate, TagSpecifications
from troposphere.events import Rule
from troposphere.msk import Cluster, Configuration
from troposphere.ssm import Parameter as SSMParameter

Expand Down Expand Up @@ -141,7 +142,7 @@ def add_object_tags(obj, tags):
:param obj: Troposphere object to add the tags to
:param troposphere.Tags tags: list of tags as defined in Docker composeX file
"""
excluded_types = (SSMParameter, Cluster, Configuration)
excluded_types = (SSMParameter, Cluster, Configuration, Rule)
if tags is None:
return
clean_tags = copy.deepcopy(tags)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ exclude = ["*.pyc", "*~", "*pycache*"]
[tool.poetry.dependencies]
python = "^3.8"
boto3 = ">=1.26"
troposphere = "^4.3.2"
troposphere = ">=4.3.2,<4.4"
ecr-scan-reporter = { version = "^0.4.8", optional = true }
compose-x-render = "^0.6.1"
compose-x-common = "^1.2"
Expand Down

0 comments on commit 698dbc6

Please sign in to comment.