Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] compose - depends_on string format support #756

Closed
JohnPreston opened this issue May 20, 2024 · 0 comments · Fixed by #757
Closed

[FR] compose - depends_on string format support #756

JohnPreston opened this issue May 20, 2024 · 0 comments · Fixed by #757
Assignees
Labels
enhancement New feature or request

Comments

@JohnPreston
Copy link
Member

In recent compose changes, there is now more details about the depends_on conditions.

    depends_on:
      broker:
        condition: service_started

The valid list is

  • service_started
  • service_healthy
  • service_completed_successfully

Which aligns very well with the existing deploy.labels ecs.depends.condition

If the user sets either, import. If the user sets both, use the deploy.labels value as this is clearly the expected behaviour for compose-x to follow.

@JohnPreston JohnPreston added the enhancement New feature or request label May 20, 2024
@JohnPreston JohnPreston self-assigned this May 20, 2024
@JohnPreston JohnPreston linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant