[BUG] ECS ContainerDefinition has broken Environment entries for Secrets #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/elbv2 conditions no access
|
I presume the ELB changes in here are due to a rebase/merge you'd done from the other branch? |
|
Oops yes, those are from your fixes for #696 that I pulled to test. If you merge that they should go away. |
|
@JohnPreston - I updated my branch to your main so the diff is correct now |
|
Closing this PR as no longer needed |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707
@JohnPreston
I know this is is a bit of a dirty hack - I don't expect you to accept this fix necessarily.
I can confirm that it does work though, so removing whatever is creating the
Environment:entries should do the same thing.