[clazy] Add package #26040
Draft
[clazy] Add package #26040
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
previously approved these changes
Nov 28, 2024
recipes/clazy/all/conanfile.py
Outdated
Comment on lines
28
to
30
| def validate(self): | ||
| if not str(self.settings.compiler).endswith("clang"): | ||
| raise ConanInvalidConfiguration(f"{self.ref} support only clang compiler") |
There was a problem hiding this comment.
This seems like a build restriction as this is an application, so this check should be done inside def validate_build()
recipes/clazy/all/conanfile.py
Outdated
| raise ConanInvalidConfiguration(f"{self.ref} support only clang compiler") | ||
|
|
||
| def build_requirements(self): | ||
| self.tool_requires("llvm-core/13.0.0") |
There was a problem hiding this comment.
Do we not expect users that already have clang to have the tools necessary to compile this app?
Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress.
Summary
Changes to recipe: lib/[version]
Motivation
Details