Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] final bump from RC doesn't print bump information #116

Open
bruce-ricard opened this issue Aug 12, 2020 · 0 comments
Open

[BUG] final bump from RC doesn't print bump information #116

bruce-ricard opened this issue Aug 12, 2020 · 0 comments

Comments

@bruce-ricard
Copy link

This code works well for me in every case I've tested it, except for when trying to bump final an input of the type 1.2.3-rc.1. The resource appears to bump correctly to 1.2.3 when I look at the next steps of the job, but it does NOT print the exptected

bumped locally from 1.2.3-rc.1 to 1.2.3

Which makes it look like the input version was NOT bumped.

It's possible that this compare function isn't doing the right thing. But both the tests and the code seem pretty convincing to me at first glance.

cc: @adobley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant