Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_ssl_verification source config not working for git driver #145

Open
ym294 opened this issue Jan 5, 2024 · 0 comments
Open

skip_ssl_verification source config not working for git driver #145

ym294 opened this issue Jan 5, 2024 · 0 comments
Labels

Comments

@ym294
Copy link

ym294 commented Jan 5, 2024

Describe the bug

When trying to use "skip ssl verification" option for git driver in semver Resource type for concourse a GO error occurs:

fatal: bad boolean config value "'false'" for http.sslVerify

I believe this is caused by the syntax on line 181 in /driver/git.go of this repo:

181: gitSkipSSLVerification := exec.Command("git", "config", "--global", "http.sslVerify", "'false'")

where the false string is in single quotes surrounded by double quotes.

Reproduction steps

  1. Initialise a semver resource in Concourse YAML config with "skip_ssl_verification: true"
  2. Run in pipeline
    ...

Expected behavior

The resource should check and initialise without the need for SSL verification when using the git driver in the semver resource.

Additional context

No response

@ym294 ym294 added the bug label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant