-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spake2.txt #357
Open
matter-it-does
wants to merge
2
commits into
conda-forge:main
Choose a base branch
from
matter-it-does:matter-it-does-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create spake2.txt #357
matter-it-does
wants to merge
2
commits into
conda-forge:main
from
matter-it-does:matter-it-does-patch-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@conda-forge-admin, please ping conda-forge/magic-wormhole-feedstock |
1 task
cc @CJ-Wright |
It's not workhole that's broken. It's spake2. You should mark |
Ugh we should add syntax so the bot ignores the |
@conda-forge-admin, please ping conda-forge/magic-wormhole-feedstock |
@conda-forge-admin, please ping conda-forge/magic-wormhole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on spake2 is not working. When installing wormhole,
linux-64/spake2-0.8-0.tar.bz2
is downloaded. This doesn't work with the error message in conda-forge/magic-wormhole-feedstock#12 . It installs files inlib/python2.7/site-packages/spake2
Right dependency is
noarch/spake2-0.8-py_3.tar.bz2
. It installs files insite-packages/spake2
.Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core
) try to make a decision on these requests within 24 hours.Checklist:
broken/*
for adding thebroken
label,not_broken/*
for removing thebroken
label, ortoken_reset/*
for token resets)