Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build for PyPy on Windows #65

Open
tyrius02 opened this issue Apr 20, 2023 · 6 comments
Open

Cannot build for PyPy on Windows #65

tyrius02 opened this issue Apr 20, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@tyrius02
Copy link
Contributor

Comment:

Portalocker on Windows depends on pywin32.win32con. Unfortunately the PyPy package of pywin32 does not include this module, causing the build to fail.

@tyrius02 tyrius02 added question Further information is requested bug Something isn't working and removed question Further information is requested labels Apr 20, 2023
@tyrius02
Copy link
Contributor Author

@conda-forge/core pywin32 itself shouldn't be available for pypy on windows, but apparently it is. Will adding a skip: true w/ a selector to this recipe work?
build: skip: true # [win and pypy]

or do I need to do something else?

@tyrius02
Copy link
Contributor Author

See PR #64

@hmaarrfk
Copy link

do you want pypy on linux?

@tyrius02
Copy link
Contributor Author

Though I've only used this package on Linux with PyTorch and never with pypy, I don't see why not.

@hmaarrfk
Copy link

due to the way the infrastructure works (all platforms get rebuilt for pypy together) I would rather not move this forward until we get a good resolution on pywin32.

If a user of pypy + portalocker + linux requests it, i would oblige to merge, but lets see if we can do better in the meantime.

See conda-forge/pywin32-feedstock#49

@tyrius02
Copy link
Contributor Author

Yes, I think this is the right answer. Just didn't know if pypy (or something else) could be used as a selector

Thanks for the input. Time to go look at pywin32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants